search

ho-nl / magento2-Ho_Templatehints

H&O Magento 2 Advanced Template Hints module
BSD 2-Clause "Simplified" License
269 stars 68 forks source link

work with production mode #55

Open onlinebizsoft opened 3 years ago

onlinebizsoft commented 3 years ago

I'm not sure if it is possible technically but it would be great if we can run this with production mode

Eddcapone commented 2 years ago

No, this makes no sense. You should never develop in production mode...

PascalBrouwers commented 2 years ago

Nothing wrong with testing your code also in production mode. @onlinebizsoft did you experience any issue with running Ho_Templatehints with production mode?

Eddcapone commented 2 years ago

@PascalBrouwers This is not a tool which is about testing and it is not good for performance.

onlinebizsoft commented 2 years ago

@Eddcapone "production mode" can be enabled on many environment (data entry site, content-preparation site, QA site, stage site,....etc), not only the production site. So I don't see any reason why we need to restrict this if users still want to enable it on in the production mode @PascalBrouwers it doesn't work if production mode is enabled (doesn't show any information)

PascalBrouwers commented 2 years ago

Hmm ok, then we need to look into it.

Eddcapone commented 2 years ago

Because it is not best practice. You should have a development instance and a production one.

onlinebizsoft commented 2 years ago

@Eddcapone we have separated instances but I mean on some instances we may set production mode for using.

Eddcapone commented 2 years ago

@onlinebizsoft Then activate it on the development instance ^^ why do you need it in production?

PascalBrouwers commented 2 years ago

@onlinebizsoft just ignore him. It's a valid point and we'll look into it why it's not working during production mode