search

ho-nl / magento2-Ho_Templatehints

H&O Magento 2 Advanced Template Hints module
BSD 2-Clause "Simplified" License
269 stars 68 forks source link

Hyva Theme compatibility? #60

Open itaymesh opened 1 year ago

itaymesh commented 1 year ago

Greetings, Does this module compatible with the Hyva theme? Thanks Itay

jeroenbalk-adwise commented 1 year ago

Hi itaymesh,

I was just looking into this because I had the same question. I tried it and it's not. This is because hints.js depends on requirejs, jquery, etc.

Since the javascript part isn't that complex, maybe it's possible to rewrite it to vanilla js and load it in a phtml or something. It will be faster and compatible.

PascalBrouwers commented 1 year ago

This module is to be used for Magento based theming if I'm not mistaken. Of course you are free to create a PR that creates some compatibility as long as it keeps working in a vanilla Magento installation.