search

ho-nl / magento2-ReachDigital_TestFramework

Faster drop-in replacement for Magento's integration test.
MIT License
76 stars 13 forks source link

Fix dependencies for 2.4 #20

Closed jissereitsma closed 4 years ago

jissereitsma commented 4 years ago

This PR upgrades the dependencies to match with Magento 2.4. I've confirmed this by running a local copy of the RD framework together with Magento 2.4 and then running all Magento 2.4 tests. I've replaced the dotmailer package using a composer replace trick, because of their tests not being compatible with PHPUnit 9. Also, there is a weird issue with a private constant that should be public in vendor/magento/module-theme/Block/Html/Title.php - yet another reported issue. But after fixing these known issues, the Integration Tests run fine.

paales commented 4 years ago

@jissereitsma Sorry I missed your PR. Could you perhaps rebase and I'll merge 👍

jissereitsma commented 4 years ago

Fixed