search

ho-nl / magento2-ReachDigital_TestFramework

Faster drop-in replacement for Magento's integration test.
MIT License
76 stars 13 forks source link

Issue fixed 2.4.1 #23

Closed jissereitsma closed 3 years ago

jissereitsma commented 3 years ago

https://github.com/ho-nl/magento2-ReachDigital_TestFramework/issues/22

paales commented 3 years ago

Somehow I didn't notified of this PR (and your issue), changed some notification preferences and should be better now.

Looks good, have you had the chance to test this version on 2.3.x as well? We still have some projects running on that version.

Could you perhaps rebase and name the the commit something like: feat: support for new overrides feature introduced in Magento 2.4.1 This way it automatically gets added to the release notes. (https://github.com/semantic-release/semantic-release#commit-message-format)

jissereitsma commented 3 years ago

Yes, this works still fine with Magento 2.3 as well - I'm still running that actively as well during development myself, plus in a custom CI chain.

Instead of rebasing, I've added the feature to the CHANGELOG in my PR. Hope that's ok as well?

paales commented 3 years ago

@jissereitsma Good enough :) I'll add it to the release notes

paales commented 3 years ago

Available in the 1.4.0 release!

jissereitsma commented 3 years ago

Awesome, thanks!