search

ho-tex / oberdiek

Updating the oberdiek bundle
Other
16 stars 6 forks source link

Don't use module(...) #70

Closed zauguin closed 5 years ago

zauguin commented 5 years ago

The module function has been deprecated with Lua 5.2 and hidden behind compiler flags. It will finally be removed in Lua 5.4 and even before that package.seeall wasn't exactly recommended. It leads to namespace pollution (e.g. you could use oberdiek.luacolor.tex.sprint("something") thanks to package.seeall) and makes the code slightly slower.

So I recommend to drop all uses of module.

davidcarlisle commented 5 years ago

Thanks for this! I noticed when we first picked up these files that it was using the old form but put it to one side, There will need to be some matching version/date changes but I'll sort it out thanks.