search

hoa-le / metadata-extractor

Automatically exported from code.google.com/p/metadata-extractor
0 stars 0 forks source link

Canon Flash Bits - the bit shift operator should be a right shift instead of a left shift. #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In CanonMakernoteDescriptor.java method getFlashDetailsDescription(), the bit 
shift operator should be a right shift instead of a left shift.  

Using the code as written, you get output like: 
[Canon Makernote] Flash Details = Unknown (8192)
or
[Canon Makernote] Flash Details = Unknown (16392)

But with the right shift operator the output is correctly displayed as:
[Canon Makernote] Flash Details = Internal flash
or 
[Canon Makernote] Flash Details = External E-TTL

There is a sample image "Canon IXUS 300.jpg" already in the sample-images 
folder that can be used to duplicate this.

Original issue reported on code.google.com by chelsea....@southsound911.org on 24 May 2012 at 6:15

GoogleCodeExporter commented 9 years ago 
Great spot! Thanks for reporting this one.

Fixed in version 2.6.1 (releasing momentarily)

Original comment by drewnoakes on 24 May 2012 at 9:37