Translation attempted even when no input was provided

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Don't type anything into the "To translate" box ("Enter the text to
translate" will be shown, greyed-out).
2. Click the "Translate" button.

What is the expected output? What do you see instead?

The status area shows "Translating...", then "Translation found". The
"Translation" box will show the greyed-out text "The translation will
appear here".

What version of the product are you using? On what operating system?

A build from 2008-09-22, on SDK 0.9 emulator.

Please provide any additional information below.

The ActivityTranslate.onClick() handler is invoking
ActivityTranslate.doTranslate() without checking for user input via the
maybeTranslate() method.

Original issue reported on code.google.com by danielr...@gmail.com on 22 Sep 2008 at 5:19

Attachments:

• maybe-translate.png

[GoogleCodeExporter]

A patch fixing this bug by calling maybeTranslate() in response to onClick(), 
rather
than just immediately firing doTranslate().

Original comment by danielr...@gmail.com on 22 Sep 2008 at 5:21

Attachments:

• maybe-translate.patch

[GoogleCodeExporter]

This patch was applied in r65, along with some other changes. r66 is also 
required
for a clean build, due to some files not committed in r65 related to the other 
changes.

This issue can be marked fixed now.

Original comment by danielr...@gmail.com on 22 Sep 2008 at 6:50

[GoogleCodeExporter]

Original comment by cbe...@gmail.com on 22 Sep 2008 at 7:33

• Changed state: Fixed