hoangduit / openmeetings

Automatically exported from code.google.com/p/openmeetings
0 stars 0 forks source link

After image loaded to draw area, pressing Undo arises infite loop #460

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Screen locked and modal "Loading Image Data" window shown.

Original issue reported on code.google.com by net...@gmail.com on 21 May 2008 at 9:32

GoogleCodeExporter commented 9 years ago

Original comment by cedric.c...@uperto.com on 21 May 2008 at 1:26

GoogleCodeExporter commented 9 years ago
client/modules/conference/whiteboard/base/imageForDrawView.lzx
line73
-this.refObj.sendLoadNotificationImage("imageloadcomplete");
+this.refObj.sendLoadNotificationImage("imagesynccomplete");

client/modules/conference/whiteboard/base/swfResourceView.lzx
line70
-this.parent.refObj.sendLoadNotificationSWF("swfloadcomplete");
+this.parent.refObj.sendLoadNotificationSWF("swfsynccomplete");

That seem to do the job, but frankly I do not understand fully this part of the 
code.
If we do that, *loadcomplete become useless?

Original comment by cedric.c...@uperto.com on 22 May 2008 at 2:58

GoogleCodeExporter commented 9 years ago
imageloadcomplete: 
means that you have successfully loading an image

imagesynccomplete:
means that all connected clients have successfully loaded the Image. This 
Events is
only broadcasted by the initial Loader of the Image 
=> the Moderator == initial Loader

Flow:
1) Moderator loads an Image to the Whiteboard and spread all connected clients 
of
that room the Notification to load a new Image, and shows the message *waiting 
to
syncronize*, he also holds a list of all connected clients
2) Every Client of that room receives the Notification and loads the Image, if 
they
have loaded the image they send the moderator the *imageloadcomplete*, and wait 
also
till everybody is syncronized
3) The moderator receives the *imageloadcomplete* from every client, if all 
clients
on his list have send the *imageloadcomplete* he(the moderator) sends a
*imagesynccomplete* Notification to all Clients
4) Every Client who receives the *imagesynccomplete* removes the 
*waiting/loading for
syncronize* message popup

[5) If a user disconnects while loading an image the Moderator removes the user 
from
the list, controls if all Users have loaded the image and if so he sends the
*imagesynccomplete* Notification]
[6) If loading of an Image Fails, each client also sends the *imageloadcomplete*
Notification]

swfloadcomplete / swfsynccomplete is the same, but for converted SWF-Documents.

----
I don't think that your fix does do the right thing, but it bypasses some sync
events. We got to review that again to check where the loop is coming from.

Original comment by seba.wag...@gmail.com on 22 May 2008 at 3:12

GoogleCodeExporter commented 9 years ago
I've tested this and it's working fine for me.  It's been open a while so 
probably 
fixed.

Original comment by lee.archer@thebigword.com on 10 Mar 2010 at 3:48

GoogleCodeExporter commented 9 years ago
I'll handle this one.

Original comment by seba.wag...@gmail.com on 30 Jul 2011 at 12:47

GoogleCodeExporter commented 9 years ago
I'm facing the same problem here, and cause of the infinite loop the system is 
getting hung every time after doing undo in the draw area after uploading the 
image there.. no idea how to resolve this issue.. any help would be really 
appreciated.

Regards,
Competent SEO
http://www.competentseo.in/

Original comment by ad...@competentseo.in on 15 Sep 2011 at 7:35

GoogleCodeExporter commented 9 years ago
did you verify that with the latest version?

Original comment by seba.wag...@gmail.com on 15 Sep 2011 at 7:37

GoogleCodeExporter commented 9 years ago
I was not able to reproduce the issue with the latest revision.

I have been testing with version 1.8.2 and tried some combinations.
If you still face some issue here please give us exact steps to reproduce.

Sebastian

Original comment by seba.wag...@gmail.com on 24 Sep 2011 at 10:03