search

hoangduit / openmeetings

Automatically exported from code.google.com/p/openmeetings
0 stars 0 forks source link

No confirmation on user logout #681

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Which version of OpenMeetings are you running?
latest

When a user presses the logout button, he is instantly logged out without a 
confirmation dialog, which may cause some grief. I've made a patch that 
shows the localized dialog asking if the user is sure to logout, attached 
to this message. As well as the patch adding the localization strings to 
the config.xml file, they are required for the patch to work properly.

Original issue reported on code.google.com by volkov.r...@gmail.com on 6 Apr 2009 at 11:06

Attachments:

GoogleCodeExporter commented 9 years ago 
Rodion, 
I think it worth using something like sure_to_logout_question instead of
you_sure_question to link the localization item to the logout scenario.

I cannot find where are you using localization labels in the code. Could it be 
that
more changed files should be added to the patch?

I believe the localization placeholder should be added to all localization xml 
files
to make translation to other languages possible. 

Thanks!

Original comment by alexei.f...@gmail.com on 6 Apr 2009 at 11:25

GoogleCodeExporter commented 9 years ago 
a) the localized string name can be of any value since this name isn't actually 
used 
anywhere
b) that's because you aren't much in the laszlo stuff - take a look at this:

<class name="logoutConfirm" extends="labelExplorerBox" labelid="622"
<labelText fontstyle="bold" y="25" labelid="623" x="10" width="270" />
<simpleLabelButton name="ok" x="20" y="50" labelid="54" width="120" height="20">
<simpleLabelButton name="cancel" x="140" y="50" labelid="55" width="120" 
height="20">

those resources all have labelid set to the appropriate value from the language 
file

c) As for adding the localization strings to every language file, I somehow 
believed 
that you only have to add the new strings only to the english file, others will 
use 
them in case they don't have their own, but this does not seem to be the case 
now, so 
thanks and here is the patch fixing the strings in every language file.

Original comment by volkov.r...@gmail.com on 6 Apr 2009 at 11:51

Attachments:

GoogleCodeExporter commented 9 years ago 
Rodion,
Thanks for fixing languages. I also understand you point on ids now. I wonder 
if it
is possible to access a label by name rather than id from the Laszlo code - it 
is
much more readable.

As for the question name, it becomes a minor issue because these names seem to 
be
never used. Nevertheless, let me try to explain my point. I see that other
localization entries are named with respect to a dialog they represent, e.g.
savecontent_confirm_cancel_btn. As for your labels, the latter one is named 
with no
relation to the logout dialog.

Original comment by alexei.f...@gmail.com on 6 Apr 2009 at 12:11

GoogleCodeExporter commented 9 years ago 
okay, in the patch attached to this message string names are changed to 
"logoutConfirm_title" and "logoutConfirm_sure_to_logout_question" respectfully 
as 
well as it is fully compatible to the previous one so it can be used instead.

Original comment by volkov.r...@gmail.com on 6 Apr 2009 at 12:33

Attachments:

GoogleCodeExporter commented 9 years ago 
Re-based the patch so it can be applied to the latest trunk.

Original comment by alexei.f...@gmail.com on 13 Apr 2009 at 3:34

Attachments:

GoogleCodeExporter commented 9 years ago 
I've tested this patch for r1980 and found, that it fixes the problem.

Original comment by e.rovin...@gmail.com on 14 Apr 2009 at 12:03

GoogleCodeExporter commented 9 years ago 
I have re-based the patch for the new revision shifting localizations even 
further.

Original comment by alexei.f...@gmail.com on 27 Apr 2009 at 2:44

GoogleCodeExporter commented 9 years ago 
Sorry, here are changes

Original comment by alexei.f...@gmail.com on 27 Apr 2009 at 2:49

Attachments:

GoogleCodeExporter commented 9 years ago 
I have tested my re-base, and all worked as expected. Rodion, I have noticed 
that the
English text slides one pixel left and right when I move the mouse inside the
confirmation window up and down.

Original comment by alexei.f...@gmail.com on 27 Apr 2009 at 4:49

GoogleCodeExporter commented 9 years ago 
The patch is applied at r1993, r1994. Please check that it works as expected.

Original comment by alexei.f...@gmail.com on 28 Apr 2009 at 12:42

GoogleCodeExporter commented 9 years ago

Original comment by seba.wag...@gmail.com on 29 Aug 2011 at 8:03