INCR listed on all updates after manual update check

[GoogleCodeExporter]

First this is not a Bugtracker for Cyanogen-Rom Bugs. Only for the updater.
The other Bugtracker can be found here:
http://code.google.com/p/cyanogenmod/issues/list

What steps will reproduce the problem?
1.Run update check more than once
2.
3.

What is the expected output? What do you see instead?

Will list all updates as INCR after manual check for updates

Please provide any additional information below.

When preforming an update check manually more than once all updates
including themes will be displayed as INCR even if they are not included in
the JSON as INCR.

I have looked at the code in the updater for INCR but am unsure why it is
listing everything as INCR after checking manually for updates.

I am looking into this problem as well but have not found the problem yet. 

Also would you mind sharing the "check" that you have implemented for the
sd card check at start. I have implemented the check i posted earlier into
the updaters that i am using but wondered if you have come up with a better
idea. 

Any info on he INCR would be great maybe a place to start looking?

Original issue reported on code.google.com by Zipste...@gmail.com on 31 May 2010 at 9:17

[GoogleCodeExporter]

HM...will have a look for it (maybe its the JSON).

SDCard check:
http://code.google.com/p/cyanogen-updater/source/detail?r=630

Original comment by FireFart on 31 May 2010 at 9:20

[GoogleCodeExporter]

Can you enable Debugoutput in Advanced Settings, restart the app, check for 
updates 
again and then post the output from
adb logcat cmupdater:V *:S
??
thanks

Original comment by FireFart on 31 May 2010 at 8:14

[GoogleCodeExporter]

I compiled the new fixes (r628-r633) into my updater and the INCR problem is 
now fixed. 

It must have had something to do with the connection settings i am guessing. 

If you still need a logcat let me know i will load the old version back on and 
then
post a logcat. But since it is no longer listing everything as INCR I think you 
dont
have to worry about it.

Original comment by Zipste...@gmail.com on 1 Jun 2010 at 6:33

[GoogleCodeExporter]

ok
I did a little bit of code cleanup, maybe this was the failure.
Another thing that could cause it:
On every updatecheck the updater diffs the found updates against the cached 
ones, and
removes the ones that are not in the new updatechecklist. So if there was an 
error on
an updatecheck, the incr updates get removed on the next updatecheck. So maybe 
this
problem still exists

Original comment by FireFart on 1 Jun 2010 at 6:52

[GoogleCodeExporter]

I will keep testing on the new code. So far I have opened the app multiple 
times and
checked for updates manually and the non INCR updates are staying non INCR 
which is a
good thing. 

I have also made some additions to the JSON list and it is still working as 
normal. 

If anything comes up I will post here with a logcat. 

Original comment by Zipste...@gmail.com on 1 Jun 2010 at 7:10

[GoogleCodeExporter]

So far this issue seems to be gone. i would mark as resolved :)

Original comment by Zipste...@gmail.com on 7 Jun 2010 at 12:13

[GoogleCodeExporter]

Fixed ;)

Original comment by FireFart on 7 Jun 2010 at 7:26

• Changed state: Fixed

[GoogleCodeExporter]

I don't want to start a new thread but I wanted to talk to you about nandroid 
support, 4g support and a couple other things. I have built off your code and 
added a new "Extras" section for well extras like VVM, Google Shits, small 
updates, and add on features, also I updated the UI in the updater. I would 
like to add more features like the ones mentioned above. I am not as good as a 
coder as you are but I am learning quickly so far. I have looked into the 
nandroid support but at this point it seems that the recoveries do not support 
it. I ran across the clockwork recovery which supports nandroid backups 
initiated from within android but his recoveries are lacking support for many 
devices and are not as complete as the amon-ra cyanogen variants. I have been 
looking at ways to get this working but ideas are short so far. At this point 
making nandroid backups is very inconvenient for users to make when using the 
updater. I am looking to add a third button for now on the Apply Update screen 
to only boot into recovery and not apply the update so the user can nandroid 
first. You can mail me at my name @gmail if you want to talk more.   

Original comment by Zipste...@gmail.com on 8 Jun 2010 at 2:33