hoangvvo / nextjs-mongodb-app

A Next.js and MongoDB web application, designed with simplicity for learning and real-world applicability in mind.
https://nextjs-mongodb.now.sh/
MIT License
1.54k stars 289 forks source link

Small fixes for the reset password flow #74

Closed sabarasaba closed 4 years ago

sabarasaba commented 4 years ago

Hey!

First of all, nice job with the repo. I've been looking around for a nice starter kit for next with basic auth already set up and yours was the one that resonated the best with me.

While I was adding my own things on of yours I decided to test the full auth flow and found this little bugs, mostly typos from what I can see.

Cheers!

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hoangvvo/nextjs-mongodb-app/kh32m6b5k ✅ Preview: https://nextjs-mongodb-app-git-fork-sabarasaba-master.hoangvvo.now.sh

hoangvvo commented 4 years ago

Hey thanks @sabarasaba! Not sure how I missed that (probably come when I try to rewrite it using next-connect a while ago).

Did the flow work with a SendGrid token (if you have one) or your own email service? The earlier codebase worked but I did not actually test it lately since I don't have a working SendGrid token.

sabarasaba commented 4 years ago

haha yeah I figured must've been something like that! I had a dummy sendgrid account already created so I tested it with that and worked just fine :)

hoangvvo commented 4 years ago

@sabarasaba Awesome! Thanks for the PR :100:

I tried to create a dummy SendGrid account too but it seemed they flag that account and IP so I can't sign up for new one :rofl: