search

hoaphantn7604 / react-native-element-dropdown

A react-native dropdown component easy to customize for both iOS and Android.
MIT License
1.01k stars 173 forks source link

Dropdown height css #281

Open trangqt2908 opened 5 months ago

trangqt2908 commented 5 months ago

image

E đang gặp vấn đề về chiều cao của Dropdown khi nội dung lớn hơn 1 dòng thi nội dung ko thể hiển thị hết. Sau khi kiểm tra thì e thấy rằng trong code đang được fix là 35 như ảnh đính kèm. A có thể bỏ thuộc tính đó trong package được không ạ.

I'm having a problem with the height of the Dropdown when the content is larger than 1 line so the content cannot be displayed completely. After checking, I see that the code being fixed is 35px like the attached photo. Can you remove that attribute from the package?

MoOx commented 5 months ago

I am facing the same problem. My context is that I have plenty of dropdown, that should be small, but the hardcoded height in the codebase, that cannot be override by any mechanism, is problematic for me.

@hoaphantn7604 are you open to a PR that could allow user to add style to the dropdown (non breaking change), so we can adjust the height ? I have a patch prepared ready to be send :)

arelstone commented 3 months ago

Thank you for making this a patch version 💀 You never feel like you have lived when you don't have production incidents