hoaproject / Central

Hoa is a modular, extensible, and structured set of PHP libraries.
https://hoa-project.net/
Other
104 stars 8 forks source link

steps for next version - bc break #74

Open Grummfy opened 7 years ago

Grummfy commented 7 years ago

Hello, as discussed, we have several task to do for a next version:

But two question:

Hywan commented 7 years ago

Upgrading to PHP 7.1 because:

So, scalar type declarations and hoa/option will introduce a natural BC break. The goal is to combine this BC break with the drop of PHP 5.x, which is implicitely a BC break too.

The plan would be to:

  1. Release hoa/option,
  2. Update hoa/consistency to use PHP 7.1,
  3. And update all the other libraries in popularity/dependency order.

Thoughts?

Grummfy commented 7 years ago

oki but for me, the plan seems correct.

But for me I'm not seeing how to help, on the following points:

For me, I see nice idea that have been implemented (iterator is precise, option is nice and nearly ready). But about other library impact, I don't see what to do to help on it. Perhaps I miss something.

Hywan commented 7 years ago

@Grummfy Updating the code to PHP 7.1 is something concrete: Adding type declarations, using PHP 7.x new features (remove all the call_user_func for instance) etc. During this process, add new documentation, and use hoa/option where possible. This must be debated but there is no hard rule: Use it when it makes sense. We can split this work in many PR of course.

Grummfy commented 7 years ago

so perhaps we can have a branch for all of these?

Hywan commented 7 years ago

Hmm, not. We can release hoa/option, then release hoa/consistency (with a BC break), then release hoa/exception (with a BC break), then release hoa/ruler (with a BC break) etc. Why should we need new branch?

Grummfy commented 7 years ago

oki. that's fine

Grummfy commented 6 years ago

we also need to drop the usage of resolve() function