search

hoaproject / Compiler

The Hoa\Compiler library.
https://hoa-project.net/
453 stars 47 forks source link

Update to PHP 7.4/PHPUnit #109

Closed sanmai closed 4 years ago

sanmai commented 4 years ago

GitHub seemingly cannot fathom that many files are not removed, just renamed. You should be able to see that all previous tests remain the same, only inside atoum/ not Test/.

Changes:

TODO:

I think I want to be clear with my development approach. If you don't like it, and, say, if you're repelled by a switch to PHPUnit, and if you can't bear anything else... No problem, hope someone else could do that in a way to the best of your liking.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 33.066% when pulling 1fd40c645899af50624233f69cb32b41e1fbe663 on sanmai:master into c620f44deff0b4c2d0c27560a3b0f5e7e376e001 on hoaproject:master.

sanmai commented 4 years ago

@Hywan any update?

I don't wish to spend time here going over TODOs if this does not make sense to you.

If you were to punch a yellow "Abandon" button here, it'll work just as well as accepting this PR. I can't seriously push a replacement package to the people if the source isn't yet officially abandoned.

blmage commented 4 years ago

@sanmai Thanks for all the work you put into cleaning up/improving the library!

There is (at least) one other fix that I would need in order to be able to finish up my own fork of the Hoa\Regex library, would you accept a corresponding PR on sanmai/hoa-compiler, or should I rather roll another fork?

sanmai commented 4 years ago

I will be happy to consider a PR.

-- Alexey

On Fri, May 1, 2020, at 22:55, blmage wrote:

@sanmai https://github.com/sanmai Thanks for all the work you put into cleaning up/improving the library!

There is (at least) one other fix https://github.com/blmage/hoa-compiler/commit/7f282dce9f2b8fd56c526bd8e577b951e211c9f8 that I would need in order to be able to finish up my own fork of the Hoa\Regex https://github.com/hoaproject/Regex library, would you accept a corresponding PR on sanmai/hoa-compiler https://github.com/sanmai/hoa-compiler, or should I rather roll another fork?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hoaproject/Compiler/pull/109#issuecomment-622398097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCBYHGASGCNDAE34FDNSDRPLIDPANCNFSM4LDVJUEQ.

sanmai commented 4 years ago

Since jms/serializer no longer depends on this package, I have no option but to retract this proposal for time being.