search

hoaproject / Contributions-Symfony-RulerBundle

The Hoa\Ruler Symfony2 bundle.
http://hoa-project.net/
Other
15 stars 4 forks source link

First version #1

Closed K-Phoen closed 8 years ago

K-Phoen commented 8 years ago

First version of the bundle integrating Hoa\Ruler in Symfony.

Right now, the bundle has few features. It exposes Ruler through a service and integrates it in the profiler. You can read more on these two features in the bundle's readme.

Some people might want to review this PR before we merge it (poke @Hywan, @stephpy & @jubianchi ?)

jubianchi commented 8 years ago

Awesome! I'll try to review this today

stephpy commented 8 years ago

Looks awesome. :+1:

Hywan commented 8 years ago

Look awesome! I made a quick first review. I let @jubianchi lead a deeper review :-).

K-Phoen commented 8 years ago

@Hywan I updated my PR to fix some of the things you noticed, I'll update the rest once I have your answer on the naming-related stuff :)

Hywan commented 8 years ago

@K-Phoen: Done.

Hywan commented 8 years ago

ping? What is the state of this PR?

K-Phoen commented 8 years ago

Should be ready for a first release, sorry for the delay :|