search

hoaproject / Devtools

The Hoa\Devtools library.
https://hoa-project.net/
6 stars 6 forks source link

Split the core #27

Closed Hywan closed 8 years ago

Hywan commented 8 years ago

Address https://github.com/hoaproject/Core/issues/96.

The core is being splitted into several libraries. Hoa\Event is one of them.

shulard commented 8 years ago

Do you think that composer.json must be updated to require hoa/event directly ?

Personally, I prefer to have direct dependencies declared in composer.json.

Hywan commented 8 years ago

@shulard No because we are not using it directly. This is like interface, we do not require them, we just “use” them as type-hint, no instance. Thoughts?

shulard commented 8 years ago

@hywan, yes but if you use the Hoa\Event\Bucket even only for type hint it must be loaded. I think that with that update you can't use hoa/devtools without requiring hoa/event.

Hywan commented 8 years ago

@shulard If your code works, it means that Hoa\Event exists somewhere else (at least from the source of the event), so it is actually somewhere.

shulard commented 8 years ago

Ok, I understand because we rely on Console\Processus and the hoa/event is loaded with hoa/console so it's ok... You're right, in that case we are "just" implementing a Processus object. Thanks for the clarification :smile:

Hywan commented 8 years ago

Correct!