Open 1e1 opened 8 years ago
Is it identical to POST
? If yes, we can merge the case
in the switch
instead.
It seems correct but it changes the specifications. In the previous version PUT requests never read $_PUT data. And I don't know how work PATCH requests. Can we send data?
If @Metalaka has not time to be the reviewer, maybe @jubianchi could do the review.
@jubianchi Yes, Can you do the review ?
I'm on it
The code seems ok to me. The rfc5789 does not talk about any restriction on PUT and PATCH request.
They might both have a body with a appropriate content type. Here we handle form-data and json correctly. Everything else is just read from the input and returned. Fine, we have a common solution to handle everything else.
It's a :+1: for me.
How shall you I process for the second review? I push an amend? I push a new commit? I open another PR?
@jubianchi ping?
@1e1 amend and then force push is good.
OK. Done.
@1e1 Your commit title is too long. Either you change it or you're allowing us to change it for you.
@jubianchi Is the PR OK for you?
@Hywan @all Indeed! I have no computer near me. If title is not changed by then, I will take care of it.
Done
Waiting on @jubianchi :-).
ping?
up
If a PUT request is sent with the header "Content-Type: application/json"
the input data will be json_decode as a POST request is decoded. (depends to the '$extended' parameter)