Fix double directory separator at the end of root.

[Metalaka]

PR for https://github.com/hoaproject/Http/issues/3.

[Hywan]

Hello :-),

Are we sure that the resolve function will add a DS (if this is a directory)? I don't think so… maybe you could rtrim / and \, and append DS.

[Metalaka]

The return value of resolve is strange, or at least not fully normalized for hoa://Application*.

So if it's not normal, we must close this PR and open another into Hoa\Core to normalize resolve.

Tests

Hoa protocol (local):

$ php Hoa.php Core:resolve hoa://Application/Public
hoa://Application/Public is equivalent to:
/var/www/hoa-learn/Application/Public/
$ php Hoa.php Core:resolve hoa://Application/Public/
hoa://Application/Public/ is equivalent to:
/var/www/hoa-learn/Application/Public/
$ php Hoa.php Core:resolve hoa://Application/Public///
hoa://Application/Public/// is equivalent to:
/var/www/hoa-learn/Application/Public/

$ php Hoa.php Core:resolve hoa://Data/Bin
hoa://Data/Bin is equivalent to:
/var/www/hoa-learn/Data/Bin
$ php Hoa.php Core:resolve hoa://Data/Bin/
hoa://Data/Bin/ is equivalent to:
/var/www/hoa-learn/Data/Bin

$ php Hoa.php Core:resolve -E hoa://Application/FakeDir/
hoa://Application/FakeDir/ is equivalent to:
/var/www/hoa-learn/Application/FakeDir

Hoa protocol (global):

$ php Hoa.php Core:resolve hoa://Library/Core
hoa://Library/Core is equivalent to:
/usr/local/lib/Hoa/Core
$ php Hoa.php Core:resolve hoa://Library/Core/
hoa://Library/Core/ is equivalent to:
/usr/local/lib/Hoa/Core

File system:

$ php Hoa.php Core:resolve /var/www/hoa-learn/
/var/www/hoa-learn/ is equivalent to:
/var/www/hoa-learn/
$ php Hoa.php Core:resolve /var/www/hoa-learn
/var/www/hoa-learn is equivalent to:
/var/www/hoa-learn

[Hywan]

So, first, are we agree that a trailing slash must be added if this is a directory? This is for security reason.

[Hywan]

ping

[Metalaka]

If we say "must be added if this is a directory", so in a first time resolve must return a trailing slash if this is a directory?

[Metalaka]

/ping @Hywan

At my mind it's better to normalize resolve, maybe do that while optimizing Hoa with PHP 5.4 ?

[Hywan]

Yes we have to normalize this. So yes, if it is a directory, we have to add a trailing slash. This is why we do in Hoa. What is the next step?

[Metalaka]

• 3 can be closed.

• Link this PR to Core#41 | Drop PHP5.3.

• 4 can be merged when resolve behaviour will be patched.

[Hywan]

What need to be patched?

[Hywan]

(ahhh, I am lost with all these PR :-p).

[Metalaka]

resolve must return a path with a trailing DS only when it's a directory.

[Metalaka]

Bhoa removed in https://github.com/hoaproject/Http/commit/9dc62172506509bab8a7ef17bed2d73e32ce061b ?

[Hywan]

@Metalaka Yup, useless since PHP has its own build-in HTTP server.

[Metalaka]

Useless yes, but cool :D

[Hywan]

Sorry, didn't check the conflict with your PR :-(!