search

hoaproject / Irc

The Hoa\Irc library.
https://hoa-project.net
25 stars 8 forks source link

Why a "mention" message was not treated like a message ? #16

Open marmotz opened 9 years ago

marmotz commented 9 years ago

IMHO, you should fire a mention AND a message event and maybe specify when a message is a mentionned message, too.

Jir4 commented 9 years ago

Actually a mention IS a message, another event is just used to be able to catch it as a specific message (because it is) and display it in another way than a "simple" message.

marmotz commented 9 years ago

Thank you to be agree with me : mention IS a message. So I want to catch all messages in "message" event, even if I was mentioned ☺

Jir4 commented 9 years ago

Ok now i see exactly what you want ^^

marmotz commented 9 years ago

You can see my reimplementation of Client::_run method and especially my rewrite of PRIVMSG messages: https://github.com/marmotz/WallIrc/blob/master/src/Irc/Client.php#L147-L178

Although, I added nick, notice, part and quit management.

Hywan commented 9 years ago

@marmotz Please, make a PR.

marmotz commented 9 years ago

with all my code ?

Hywan commented 9 years ago

@marmotz You said it's done. Well, do a PR :-).

Hywan commented 8 years ago

Still up?