resolve helper in conflict with the Laravel helper resolve

HpiGuillaume commented 5 years ago

Seems the issue #18 not resolve, Can we re-open it :pray: ?

I've write a comment on #18 but in case you don't see it because it's closed issue:

Hello, I think this issue #18 have to be re-open :/

There is a helper resolve() in .../laravel/framework/src/Illuminate/Foundation/helpers.php who conflict with yours even in a namespace :/

I have the hoa/protocol version "1.17.01.14".

hoa helper: vendor/hoa/protocol/Wrapper.php illuminate helper: vendor/laravel/framework/src/Illuminate/Foundation/helpers.php

The problem don't come from my code but from the package hyn/multi-tenant who use the resolve helper in the Laravel way. You can see it here: vendor/hyn/multi-tenant/src/Providers/Tenants/QueueProvider.php

What can I do to patch it?

sanmai commented 5 years ago

Please try:

composer require sanmai/hoa-protocol

Will that fix the issue you're having? If nothing else, please file an issue here.

precariouspanther commented 4 years ago

@sanmai it looks like a release hasn't been tagged for the commit that fixes this. The latest tagged release is: https://github.com/hoaproject/Protocol/releases/tag/1.17.01.14 and the commit was introduced here: https://github.com/hoaproject/Protocol/commit/5637cb444d535ee4ed48db23478886eb41382426

Composer wont be picking up the new commits until a release has been tagged.

sanmai commented 4 years ago

@precariouspanther that is correct, and that is why I had to publish my fork as a package.

precariouspanther commented 4 years ago

@sanmai oh apologies, I thought you were the maintainer of this repo vs the fork!

sleenen commented 4 years ago

Can it be tagged and released please... I'm running into this issue too

hoaproject / Protocol

resolve helper in conflict with the Laravel helper resolve #25