search

hoaproject / Realdom

The Hoa\Realdom library.
https://hoa-project.net/
7 stars 7 forks source link

Remove use of deprecated each() function #25

Closed npfund closed 3 years ago

npfund commented 5 years ago

each() is deprecated as of PHP 7.2: https://wiki.php.net/rfc/deprecations_php_7_2#each

Simply replacing it with a foreach wouldn't work, as the code depends on the state of the internal array pointer of $this->_arguments. I've attempted to preserve that behavior by explicitly splitting the array into the two sections that would be iterated over.

Hywan commented 5 years ago

Thanks for the PR!

guiled commented 4 years ago

Any news about it ?