Closed Metalaka closed 9 years ago
@Metalaka I don't understand where the bug was. We already has this choice for s
to be interpreted as h
or v
in the switch
. Not there is no break
, this is the trick.
However, I understand this is error prone and then your patch is welcomed. Is it why you had in mind?
Please look result of http://3v4l.org/DsOA7
The previous line $value = $this->_sampler->getInteger(0, 1) ? 'h' : 'v';
is totally useless since there is no break,
so the following case
is directly executed and the choice (h or v) is not used.
Ok :-].
Can you please reword your commit message based on http://hoa-project.net/Literature/Contributor/Guide.html#Commiting_a_patch:
It must answer to the following questions:
- What was the issue?
- How to address this issue?
- How did we address the issue?
Thanks!
Done.
Excellent, thanks!
\s
token was previously considered like\h
. Now\s
will be interpreted as\h
or\v
.