search

hoaproject / Regex

The Hoa\Regex library.
https://hoa-project.net/
310 stars 17 forks source link

Fix non-breaking space character encoding. #21

Closed Metalaka closed 9 years ago

Metalaka commented 9 years ago

Since the character code is > 128, the string representation of the character must be encoded in UTF-8 and not in ISO 8859-1 or other default value.

Related to https://github.com/hoaproject/Compiler/pull/27#issuecomment-129319732.

Hywan commented 9 years ago

Correct! Good catch. Could you also please create another commit to replace all chr calles to Ustring::fromCode, it is more consistent I guess?

Metalaka commented 9 years ago

Done.

Hywan commented 9 years ago

@Metalaka Excellent. Now please, same note as https://github.com/hoaproject/Regex/pull/20#issuecomment-130248013.

Metalaka commented 9 years ago

Done.

Hywan commented 9 years ago

Excellent, thanks!

Hywan commented 9 years ago

Merge commit: https://github.com/hoaproject/Regex/commit/1d9cb1613f144b4aceb0c02d9b05424609593d6b. Original commits: https://github.com/hoaproject/Regex/commit/f209f45054bb5bdd53742dc0918d032a91115a35 and https://github.com/hoaproject/Regex/commit/057492186d1a412bd59b761597e0ca17dca64974.