search

hoaproject / Ruler

The Hoa\Ruler library.
https://hoa-project.net
627 stars 66 forks source link

Support traversables inside `in` operator #113

Closed ostrolucky closed 2 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 97.407% when pulling 3e60a63b08ccc71eaace726d790d38195dfd4d01 on ostrolucky:in-traversable into 28174caf3be01144e7e213fce75598404570e094 on hoaproject:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 97.232% when pulling 53a28421917a400277bcee0e9a99b3b34cc812dd on ostrolucky:in-traversable into 28174caf3be01144e7e213fce75598404570e094 on hoaproject:master.

Hywan commented 6 years ago

Thanks for the PR!

ostrolucky commented 6 years ago

@Hywan No problem! So, how should we go forward with this? Do you want me to typehint to iterable and drop support for PHP < 7.1, or just change the type of exception thrown?

Hywan commented 6 years ago

@ostrolucky We are discussing about merging the php7 branch into master, so that's it's going to be much easier for you. Sorry for the late reply, I'm back from my paternity leave :-).

ostrolucky commented 6 years ago

All I see on gh is master branch, no php7?

Hywan commented 6 years ago

php7 has been merged inside master.

Hywan commented 6 years ago

Or it's about to be :-p.

ostrolucky commented 6 years ago

Still no php7. Let's merge it as it is