search

hoaproject / Test

The Hoa\Test library.
https://hoa-project.net/
11 stars 10 forks source link

Documentation: Fix typos #49

Closed dantleech closed 9 years ago

dantleech commented 9 years ago

This PR contains grammer fixes.

Hywan commented 9 years ago

Thank you very much for this deep corrections! I am ashamed there is so much corrections to do :-(. Well, there is some open questions. Keep going!

dantleech commented 9 years ago

Updated..

Hywan commented 9 years ago

Thank you for your effort!

dantleech commented 9 years ago

No problem, its a pleasure to contribute :) I have fixed the things we agreed on and there is only the "All levels are important" paragraph to resolve.

Hywan commented 9 years ago

Perfect!

dantleech commented 9 years ago

I think what you proposed for "All levels are important" makes good sense, have updated.

Hywan commented 9 years ago

So everything is ready for a new review?

Hywan commented 9 years ago

Get ready for a squash to get one commit, named: “Documentation: Clarify and fix several typos” (or something equivalent).

dantleech commented 9 years ago

Yep, ready for final review. Have squashed.

Hywan commented 9 years ago

3 tiny comments and we are good!

dantleech commented 9 years ago

Amended the commit, everything good from here.

Hywan commented 9 years ago

Thank you very much!

dantleech commented 9 years ago

Thankyou, glad to contribute to a great project :)

On Tue, Oct 27, 2015 at 06:51:46AM -0700, Ivan Enderlin wrote:

Thank you very much!

— Reply to this email directly or [1]view it on GitHub.

Reverse link: [2]unknown

References

Visible links

  1. https://github.com/hoaproject/Test/pull/49#issuecomment-151502639
  2. https://github.com/hoaproject/Test/pull/49#issuecomment-151502639
Hywan commented 9 years ago

Welcome on board: http://hoa-project.net/Community.html#Contributors :wink:.

dantleech commented 9 years ago

Thanks!

On Tue, Oct 27, 2015 at 07:00:14AM -0700, Ivan Enderlin wrote:

Welcome on board: [1]http://hoa-project.net/Community.html#Contributors

— Reply to this email directly or [3]view it on GitHub.

Reverse link: [4]unknown

References

Visible links

  1. http://hoa-project.net/Community.html#Contributors
  2. https://github.com/hoaproject/Test/pull/49#issuecomment-151504703
  3. https://github.com/hoaproject/Test/pull/49#issuecomment-151504703