search

hoaproject / Test

The Hoa\Test library.
https://hoa-project.net/
11 stars 10 forks source link

Update `test:run` default behaviour to use `Test` directory by default #55

Closed shulard closed 8 years ago

shulard commented 8 years ago

For the moment when you run the command test:run the usage help is displayed. With this PR, the Test directory is used by default if nothing is given as command parameter :

vendor/bin/hoa test:run
shulard commented 8 years ago

This PR fix the #54 issue. I tried to use the -d . but I get an error from Atoum :

Fatal error: require_once(): Failed opening required 'phing/Task.php' (include_path='.:') in /Users/shulard/Sites/Forks/Hoa/Socket/vendor/atoum/atoum/resources/phing/AtoumTask.php on line 15

So I used the Test dir...

Hywan commented 8 years ago

What oO? Really strange error. Can you investigate a little bit?

Hywan commented 8 years ago

I don't have any error when trying to run with -d ..

shulard commented 8 years ago

Yes a really strange error... I'm on a MBP and I checked with 5.6 and 7.0.0RC8 and I get the same error. I also checked with the full path instead of . and it's the same.

I think it's an Atoum error, because when I dump the Atoum generated command and run it, same behaviour :

vendor/bin/atoum --configurations vendor/hoa/test/.atoum.php --bootstrap-file vendor/hoa/test/.bootstrap.atoum.php --force-terminal --max-children-number 2 --directories .

This is the whole error message I get :

atoum is a simple, modern and intuitive PHP 5.3+ unit testing framework.
Copyright (c) 2010-2014, Frédéric Hardy.
All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

    * Redistributions of source code must retain the above copyright
      notice, this list of conditions and the following disclaimer.
    * Redistributions in binary form must reproduce the above copyright
      notice, this list of conditions and the following disclaimer in the
      documentation and/or other materials provided with the distribution.
    * Neither the name of Frédéric Hardy nor the names of its contributors
      may be used to endorse or promote products derived from this software
      without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY FRÉDÉRIC HARDY AND CONTRIBUTORS ``AS IS'' AND ANY
EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL FRÉDÉRIC HARDY AND CONTRIBUTORS BE LIABLE FOR ANY
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Fatal error: require_once(): Failed opening required 'phing/Task.php' (include_path='.:') in /Users/shulard/Sites/Forks/Hoa/Socket/vendor/atoum/atoum/resources/phing/AtoumTask.php on line 15

The constant mageekguy\atoum\phing\task\path in the file vendor/atoum/atoum/resources/phing/AtoumTask.php is not defined properly when I run the command using .. If I give Test as directory, the constant is defined...

Hywan commented 8 years ago

@shulard Can you report this error to atoum? /cc @mageekguy, @jubianchi

shulard commented 8 years ago

Of course :smile:

Issues posted on atoum/atoum#527

Hywan commented 8 years ago

Thanks!