search

hoaproject / Test

The Hoa\Test library.
https://hoa-project.net/
11 stars 10 forks source link

option to disable code coverage #89

Closed Grummfy closed 7 years ago

Grummfy commented 7 years ago

In order to fullfill the following issue https://github.com/hoaproject/Central/issues/36 as discussed in the virtual meeting of 4 july 2017, we have decided to disabled code coverage for some long test run.

The purpose, of this feature is to allow to disable code coverage scoring from test.

hoa test:run --no-code-coverage or -N will disabled the code coverage.

Hywan commented 7 years ago

Disabling code coverage will not solve our issue. We must remove xdebug, this is the source of the slowness.

Grummfy commented 7 years ago

oki, so I improve this one and for the main issue remove xdebug to run the test on the libs with issue?

Hywan commented 7 years ago

I still wonder if having an option to disable code coverage is something we would need here…

Grummfy commented 7 years ago

Well it accelerate dramatically the time to run the test, and sometimes avoid some segfault (I still have time to time on my projects). It's like you want.

Hywan commented 7 years ago

I have no strong opinions on this one. Update your PR and I will accept it :-).

Hywan commented 7 years ago

Please, try to name the commit message like something like:

feat(bin) Add the --no-code-coverage option.

Grummfy commented 7 years ago

here it is

Hywan commented 7 years ago

Thanks!