Problem when using broadcast() in the 'close' event

[Geslain]

Hi,

When i try to Use the broadcast() function on a close event in the server, if a client disconnect himself, the first remaining connected client gets disconnected and he's the only one to receive the broadcast message . Others don't receive anything.

$websocket->on('close', function ( Hoa\Core\Event\Bucket $bucket )  {
    echo "connection closed\n";
    $bucket->getSource()->broadcast("A client disconnect himself from server"));
    return;
});

To understand, here's an example :

• Client 1 connect himself to server
• Client 2 connect himself to server
• Client 3 connect himself to server
• Client 1 disconnect himself from server
• Client 2 receive message "A client disconnect from server" , and immediatly get disconnected from server
• Client 3 doesn't get any message and is still connected

[thehawk970]

In addition an little MWE for explain that :) https://gist.github.com/camael24/9c601fb14ee003ac7896

[osaris]

I've tested the @camael24 gist and I can reproduce the problem. I tried to debug but can't find where is the problem :-(

[osaris]

While discussing with @Geslain we found that the problem seems to come from :

https://github.com/hoaproject/Socket/blob/c0820fa8eee12d2d375818fe5877a0853d6a3246/Connection/Handler.php#L257

Because $old is a resource of type unknown (and we except stream) when the client disconnect. It break, disconnect the current client and stop the broadcast.

If you comment these lines

https://github.com/hoaproject/Stream/blob/d1d2388abd3581dff63a44dff9f224c006e06c21/Stream.php#L410-L413

there is no problem anymore (but it's not a solution !).

[Geslain]

A temporary solution seems to be surrounding the _setStream($old) with try catch instructions :

https://github.com/hoaproject/Socket/blob/c0820fa8eee12d2d375818fe5877a0853d6a3246/Connection/Handler.php#L267

return function ( ) use ( &$send, &$old, &$self ) {

    $out = call_user_func_array($send, func_get_args());
    try {
        $self->getConnection()->_setStream($old);
    } catch (\Hoa\Core\Exception\Exception $e) {
        echo 'Get Exception : ',  $e->getMessage(), "\n";
    }

    return $out;
};

[Hywan]

This patch https://github.com/hoaproject/Stream/pull/4 on Hoa\Stream should fix your issue. Can you confirm please?

[Geslain]

Working for me too

[Hywan]

I am asking the review of @osaris and @camael24 also :-).

[osaris]

Tested and it works. Good job !

[thehawk970]

Same hère

jeudi 24 juillet 2014 19:05 +0200 de Raphaël Emourgeon notifications@github.com: Tested and it works. Good job ! — Reply to this email directly or view it on GitHub .

[Hywan]

Closed by https://github.com/hoaproject/Stream/pull/4.