hoarder-app / hoarder

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search
https://hoarder.app
GNU Affero General Public License v3.0
2.28k stars 77 forks source link

Improve merging of tags by simple drag and drop #144 #154

Closed kamtschatka closed 1 month ago

kamtschatka commented 1 month ago

Added drag&drop functionality Allowing sorting the tags by name, as this is more intuitive

Just a crude change to get some feedback. As I am no UI dev, I am thankful for any improvement ideas.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hoarder-app-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 7:54pm
hoarder-app-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 7:54pm
MohamedBassem commented 1 month ago

Hi, thanks a lot for working on this! I tried it locally and it's really really cool! I'll review the code now :)

vercel[bot] commented 1 month ago

Someone is attempting to deploy a commit to the Mohamed Bassem's projects Team on Vercel.

A member of the Team first needs to authorize it.

MohamedBassem commented 1 month ago

@kamtschatka You can see some of the simplifications I made here (https://github.com/MohamedBassem/hoarder-app/commit/e5fd9eeca0d34658c9eed4f1a7d6ec25d4918488). Mainly:

  1. Managed to get dragging of links to work by adding data-id on the link itself on the parent div.
  2. Found a way that we won't need the initialX and initialY.
  3. handleDrag turned out to not be needed as you only care when the drag is over.
  4. Added some icons and help messages on the buttons.

Again thanks a lot for the idea and implementation!

MohamedBassem commented 1 month ago

This is what it looks like now:

Screenshot 2024-05-18 at 12 19 43 PM