hoarder-app / hoarder

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search
https://hoarder.app
GNU Affero General Public License v3.0
4.56k stars 151 forks source link

about:newtab is not recognized as a url #275

Open skirmess opened 3 months ago

skirmess commented 3 months ago

I'm using hoarder 0.14.0. When I paste the following text in the "New Item" box it gets added as text.

http://example.com/
about:newtab
http://example.net/

but when I want to add this it asks me if I want to add them as separate bookmarks.

http://example.com/
http://example.net/

I use hoarder to save a bunch of open tabs all at once like so.

Unfortunately, if there was an empty tab open it gets added as text and I have to first close this tab,

It would be nice if hoarder would recognize about:* as URLs because that's how they are used by browsers.

kamtschatka commented 3 months ago

You mean ignored? Because that can't be added to the crawler

skirmess commented 3 months ago

Ignored is fine - it's not a link I'm interested in. :-)

Same problem exists with chrome://newtab/.

Edit: and edge://newtab/

kamtschatka commented 3 months ago

I have opened a PR. Basically all the lines still need to be proper URLs to allow multi URL import, but then all non http/https URLs will be skipped. So if you type

http://www.google.at?q=asdf
about:config
chrome://newtab/
http://www.google.at?q=asdf1

only the 2 google URLs are imported.

if you type

randomstring
http://www.google.at?q=asdf
about:config
chrome://newtab/
http://www.google.at?q=asdf1

it will be imported as text still.