search

hoarder-app / hoarder

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search
https://hoarder.app
GNU Affero General Public License v3.0
6.63k stars 240 forks source link

Update meilisearch #543

Closed wuast94 closed 2 weeks ago

wuast94 commented 1 month ago

There is already an issue #426 but without any usefull information.

my main reason is security. running old containers (v1.6 is 9month old and v1.9 what i use is 3month old). running old containers is always a bad advice becouse they also have all the security issues of the base image, all old dependencys and app.

also recource usage, speed improvements etc are some things that are always nice to have.

dtomlinson91 commented 1 month ago

The Meilisearch upgrade procedure (when running in a container) is a massive pain in the arse (and I say this as someone who uses it daily).

For a project like this upgrading it in-place is practically impossible. It is going to be far easier to have people re-create their Meilisearch index on the new version and re-index.

Does the reindex all bookmarks button in the admin interface do this?

MohamedBassem commented 1 month ago

Does the reindex all bookmarks button in the admin interface do this?

That's exactly what it does yes.

wuast94 commented 1 month ago

so clearing the meilisearch data, start with new version, and then reindex all bookmarks should work?

dtomlinson91 commented 1 month ago

Yeah bring the whole stack down, backup & delete the data.ms directory (so the Meilisearch volume), bump the Meilisearch image tag and bring it back up and re-index.

MohamedBassem commented 1 month ago

@wuast94 as long as newer version of mellisearch work with their old clients (they are keeping client backward compatibility), this should work yes. Reindexing is extremely fast.

wuast94 commented 1 month ago

then i will try it the next days and report back :)

wuast94 commented 2 weeks ago

i can report it works without any issues, maybee we could update the version in the compose for new users?

MohamedBassem commented 2 weeks ago

@wuast94 thanks for reporting back! Sure we can update the compose version then.

wuast94 commented 2 weeks ago

well then i will do a PR :)

wuast94 commented 2 weeks ago

done, will close this issue then :)