Refactor: Contracts - Githubissues

hoardexchange / hoard-exchange-erc998

6 stars 8 forks source link

Refactor: Contracts #2

Closed failfmi closed 3 years ago

failfmi commented 3 years ago

Detailed description:

Refactor contracts indexes

Which issue(s) this PR fixes:

Special notes for your reviewer:

Modifiers are not added yet
~~Require messages are not added yet~~
EnumerableMap where possible
~~address.isContract lib~~
Leave suggestions if you would like

Perseverance commented 3 years ago

isContract could be taken from OpenZeppelin instead of implemented https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Address.sol