search

hobbit-project / platform

HOBBIT benchmarking platform
GNU General Public License v2.0
23 stars 9 forks source link

Organizer is used as Resource but it is a Literal #122

Closed MichaelRoeder closed 6 years ago

MichaelRoeder commented 7 years ago

Problem

In line https://github.com/hobbit-project/platform/blob/master/hobbit-gui/gui-serverbackend/src/main/java/de/usu/research/hobbit/gui/rest/ExperimentsResources.java#L155 the GUI tries to access the organizer of a challenge as Resource. However, in the model it is only available as String (=Literal). Thus, this will always return null instead of the resource.

MichaelRoeder commented 7 years ago

It causes a problem when an organizer tries to access the private results of a challenge. The user is not recognized as the organizer of the challenge and the gui-serverbackend returns an empty response that causes an exception in the gui client

Uncaught TypeError: Cannot read property 'emit' of undefined
    at DynamicFormBootstrapComponent.DynamicFormControlComponent.onFocus (main.bundle.js:18)
    at View_DynamicFormBootstrapComponent14.handleEvent_4 (/DynamicFormsBootstrapUIModule/DynamicFormBootstrapComponent/component.ngfactory.js:1220)
    at HTMLInputElement.<anonymous> (vendor.bundle.js:67)
    at ZoneDelegate.invokeTask (polyfills.bundle.js:7643)
    at Object.onInvokeTask (vendor.bundle.js:14)
    at ZoneDelegate.invokeTask (polyfills.bundle.js:7643)
    at Zone.runTask (polyfills.bundle.js:7643)
    at HTMLInputElement.ZoneTask.invoke (polyfills.bundle.js:7643)
denkv commented 6 years ago

Is this fixed?

MichaelRoeder commented 6 years ago

Yes, but it hasn't been merged into the master branch until now.