search

hobbit-project / platform

HOBBIT benchmarking platform
GNU General Public License v2.0
23 stars 9 forks source link

Challenge experiment without execution date #306

Open MichaelRoeder opened 6 years ago

MichaelRoeder commented 6 years ago

Problem

We have the following message in [our logs](https://log.project-hobbit.eu/app/kibana#/doc/logstash-*/logstash-2018.05.15/other?id=AWNk2fkuwRO_i8n6xCpO&_g=()):

2018-05-15 17:29:56,778 ERROR [org.hobbit.controller.queue.ExperimentQueueImpl] - <Got a challenge experiment without an execution date. Setting the execution date to 'now' and returning it.>

Short term goal

It should be clarified whether

  1. such a challenge can cause problems (especially in the area where the error has been logged) and
  2. which challenge is missing the date

Long term goal

It should be made sure that challenges without crucial dates can not be closed.

denkv commented 6 years ago

Challenge without execution date works fine, it just immediately executes its experiments when closed.

The observed log message apprears when experiment in the queue is considered for execution and has no associated execution date. Platform then sets it up for immediate execution.

Currently we have the following challenges with no execution dates defined:

We probably can just warn the user when closing the challenge that it will be executed immediately (done in #327), and maybe (if he agrees) automatically set execution date to current date. Can be done on the client before submitting.