search

hobbit-project / platform

HOBBIT benchmarking platform
GNU General Public License v2.0
23 stars 9 forks source link

Platform should check experiment IDs in incoming requests #320

Open denkv opened 6 years ago

denkv commented 6 years ago

When platform is restarted while there is a running experiment, platform would still create containers on request (even if platform doesn't know about that experiment). Check if same happens when storing experiment results etc.

denkv commented 6 years ago

So we should check in PlatformController::receiveCommand if provided session ID is the same as currently running experiment ID, and reject all calls where it isn't.

That will cover DOCKER_CONTAINER_START, DOCKER_CONTAINER_STOP, BENCHMARK_READY_SIGNAL, SYSTEM_READY_SIGNAL, TASK_GENERATION_FINISHED, BENCHMARK_FINISHED_SIGNAL, REQUEST_SYSTEM_RESOURCES_USAGE.

Is there any other way for experiments to communicate with platform? @MichaelRoeder

MichaelRoeder commented 6 years ago

No. We only have to add the check to this method.

MichaelRoeder commented 6 years ago

Added a fix with https://github.com/hobbit-project/platform/commit/e1cf3511a95a0fc31f971ea51f728ba2ec6f902d

denkv commented 5 years ago

Is this not merged?