search

hobbit-project / platform

HOBBIT benchmarking platform
GNU General Public License v2.0
24 stars 9 forks source link

Do not actively pull a single image several times during the single experiment #430

Closed denkv closed 5 years ago

denkv commented 5 years ago

This will speed up benchmarks like LDCBench which may want to spawn a lot of similar containers.

Fixes #429.

MichaelRoeder commented 5 years ago

It solves the issue for now. However, I thought that the experiment status is given to the container manager and the pulled images are added to the experiment status object. This would ensure that the set of pulled images does not have to be managed by the container manager since it belongs to the single experiments. :thinking:

denkv commented 5 years ago

the pulled images are added to the experiment status object

This idea came later, but we can implement it now as well.

MichaelRoeder commented 5 years ago

I would suggest it. It creates some additional effort but I think it is the cleaner implementation.

denkv commented 5 years ago

Now we have a list of image names used during the experiment in ExperimentStatus.