hobbit-project / platform

HOBBIT benchmarking platform
GNU General Public License v2.0
23 stars 9 forks source link

Remove empty KPIs from the Experiment Details page #534

Closed mjovanovik closed 2 years ago

mjovanovik commented 2 years ago

User story

As I user, I would like the empty KPIs from the Experiment Details page to be hidden. As a benchmark developer, I would like to be able to use numerous KPIs for my benchmark, but populate only a subset of the KPIs depending on the input parameters the user selected. Currently, all KPIs are shown by default, regardless of whether their value is set or not.

Solution

When I go to the results page, i.e. the Experiment Details page, I want the empty (non-populated, not-used) KPIs simply hidden and not shown on the page.

denkv commented 2 years ago

Is there an example of such experiment on https://master.project-hobbit.eu/?

denkv commented 2 years ago

I have tried to remove the value of one of KPIs for an experiment on my local instance and the corresponding row disappeared from UI. Are you certain you're not populating the KPIs?

mjovanovik commented 2 years ago

Thanks for the quick test and the reply.

Unfortunately, our specific benchmark case is currently under development, so we have no means of a quick test. We assumed (from memory, from years back) that the empty KPIs were being shown by default, and that would've been a problem for our benchmark which branches based on a combination of input parameters. And each branch has a separate set of KPIs.

But, given that your tests show that's not the case, then this feature request is already resolved :)

We'll continue with our development, and when we arrive to the test phase, we'll reopen it if necessary.