hobby-kube / guide

Kubernetes clusters for the hobbyist.
MIT License
5.57k stars 258 forks source link

Terraform borks up on `count` keyword #76

Closed lbialy closed 4 years ago

lbialy commented 5 years ago

I get this with terraform 0.12.3:

Error: Reserved argument name in module block

  on main.tf line 48, in module "swap":
  48:   count       = "${var.node_count}"

The name "count" is reserved for use in a future version of Terraform.

Apparently some renaming is now a must.

lbialy commented 5 years ago

Replacing count with node_count everywhere and version with etcd_version everywhere solves this.

masterkain commented 5 years ago

I'm having issues with 0.12 as well, did you manage to get it working?

lbialy commented 5 years ago

Yeah, just replace count variable with node_count and version variable with etcd_version everywhere.

masterkain commented 5 years ago

yes, did that in order to prepare a pr, but I met a lot of other errors, I'm away from computer but some were about unallowed var blocks. tried with latest tf version?

On Mon, Aug 12, 2019, 23:09 Łukasz Biały notifications@github.com wrote:

Yeah, just replace count variable with node_count and version variable with etcd_version everywhere.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hobby-kube/guide/issues/76?email_source=notifications&email_token=AAADELHSTDIJLT4IMQAU73TQEHGPFA5CNFSM4ICFOHJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4D2WTY#issuecomment-520596303, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADELAEO4QZWMM2AUC3ZZDQEHGPFANCNFSM4ICFOHJA .

lbialy commented 5 years ago

Hmm, not yet.

pstadler commented 5 years ago

Currently very busy here. Terraform 0.12 seems to break a lot of code. Will try to catch up as soon as possible. You should stick with 0.11 until then.

pstadler commented 4 years ago

This will be fixed with https://github.com/hobby-kube/provisioning/pull/48

pstadler commented 4 years ago

This has been fixed with https://github.com/hobby-kube/provisioning/pull/48