search

hobby-kube / provisioning

Kubernetes cluster provisioning using Terraform.
https://hobby-kube.dev/guide
MIT License
312 stars 112 forks source link

0.12 Terraform upgrade #48

Closed chris-free closed 5 years ago

chris-free commented 5 years ago

Status:

I have upgraded the core 0.12 differences to 0.11 including:

  1. Reserved names
  2. Explicit block vs resource definitions.
  3. Removing list brackets to splat variables
  4. Connection resource needs to set in 0.12 in digitalocean provider (was implicit in 0.11)

This has created a cluster on DO without DNS, though not fully tested.

to check:

  1. Give other providers a run through to check for 0.12 syntax conflicts.
  2. Test DNS
chris-free commented 5 years ago

It might make sense to create a 0.12 branch to work on?

pstadler commented 5 years ago

How could you run this without passing vpn_ip?

It might make sense to create a 0.12 branch to work on?

If you want to abandon this, I can merge it into a 0.12 branch. Let me know.

chris-free commented 5 years ago

This variable isn't used in the template file so terraform was giving an error was the reason I commented it out originally.

I am happy to continue working on this PR.

pstadler commented 5 years ago

You're right, please remove this line. 0.12 is really verbose about everything.

pstadler commented 5 years ago

Chris, could you run terraform fmt and clean up this one or two commented out lines, so we can get this ready? I'd then test against Hetzner, Scaleway and Cloudflare (DNS).

chris-free commented 5 years ago

Working on it

chris-free commented 5 years ago

Tested: Providers: Digitalocean DNS: Digitalocean/Cloudflare

I'm going to test Scaleway/Hetzner now

pstadler commented 5 years ago

In case you don't want to sign up for these services, I'd happily do the testing.

chris-free commented 5 years ago

I started a bit of it yesterday for Scaleway and I was a bit concerned by the amount of changes to the provider code I had to do to get things to start working. If you think you are better suited for it it may be a good idea. Otherwise I am happy to keep going with it

chris-free commented 5 years ago

Hi Patrick,

I've got a cluster working on Scaleway, Hetzner and DigitalOcean now. The only thing I haven't done is migrate AWS/Google DNS terraform code.

I am going to make some comments on some things it would be good to verify is ok with you.

pstadler commented 5 years ago

sure thing!

chris-free commented 5 years ago

Oops, I had a technical malfunction and forgot to click submit

Govinda-Fichtner commented 5 years ago

I did test this with Hetzner & AWS DNS today and it works.

pstadler commented 5 years ago

Many thanks @chris-free. Everything looks great besides the Scaleway sudo quirks. This can get merged after this change 🎉

pstadler commented 5 years ago

Okay, really happy with the outcome here. Will merge now and fix myself. Thanks a lot @chris-free!