It seems that api_token has never needed email - only when using api_key is email actually required. This logic is now enforced in the latest version of the provider. As we specify the non-required email it fails as it is now enforcing that api_key is not present:
╷
│ Error: Missing required argument
│
│ with module.hobby_kube.module.dns.provider["registry.terraform.io/cloudflare/cloudflare"],
│ on ../hobby-kube/dns/cloudflare/main.tf line 22, in provider "cloudflare":
│ 22: email = var.cloudflare_email
│
│ "email": all of `api_key,email` must be specified
╵
It seems that
api_tokenhas never neededemail- only when usingapi_keyisemailactually required. This logic is now enforced in the latest version of the provider. As we specify the non-requiredemailit fails as it is now enforcing thatapi_keyis not present:See https://github.com/cloudflare/terraform-provider-cloudflare/issues/1807
Commenting out
email = var.cloudflare_emailfixes it.