hobbyjobs / photivo

Automatically exported from code.google.com/p/photivo
GNU General Public License v3.0
0 stars 0 forks source link

Lumix DMC-GX1 raws apparently not read correctly #82

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. load .RW2 image from GX1
2. attempt to generate nice output

What is the expected output? What do you see instead?

I can get great results with raws from my old Lumix G1, but GX1 stuff looks 
really flat. Impossible to get good contrast or colour, even with a full-range 
histogram, it looks to me like a very compressed dynamic range.

What version of the product are you using? On what operating system?

Latest source build, on Debian Testing

Please provide any additional information below.

Rawtherapee 4.0.9 seems to work fine (good contrast and colours), so suspect 
it's a dcraw version problem. I can provide sample screenshots. Problem is 
apparent in the dpreview sample raws available here: 
http://www.dpreview.com/reviews/panasonicdmcgx1/20

Original issue reported on code.google.com by frasermc...@gmail.com on 12 Jul 2012 at 2:43

GoogleCodeExporter commented 9 years ago
Just confirmed that the latest dcraw (1.451) seems to decode GX1 raws 
correctly. I had a quick look at ReferenceMaterial/dcraw/dcraw*, 
Sources/ptDcRaw*, and ReferenceMaterial/dcraw/update.sh and I'm willing to have 
a go at updating Photivo's dcraw myself to the latest (1.451 as I write this), 
unless someone is already working on it. Any tips or tricks on how to do this, 
or is it just a run-the-script then hack it together job? Do I just need to 
update Sources/ptDcRaw.{h,cpp} or is there anything else that needs to be done?

Original comment by frasermc...@gmail.com on 17 Jul 2012 at 3:35

GoogleCodeExporter commented 9 years ago
Your help is very much aprreciated. 

Yes, we take the latest dcraw, run the script to have it in our notation, 
compare the diffs to the former dcraw and update the diffs in ptdcraw. The 
profile values go to ptAdobeTable.h. We could offer you push access to the repo 
if you plan to help more often, or we can merge your changes. 
This is the main part of the work. Afterwards one has to rebuild the profiles, 
but that is just calling the ptCreateAdobeProfiles and adding the new profiles 
to the repo. 
If there are new static variables in the diffs of dcraw, we would transfer 
these static variables to member variables in the class. I can help you with 
that, if you have any problems.

greets mike

Original comment by m...@mm-log.com on 17 Jul 2012 at 5:31

GoogleCodeExporter commented 9 years ago
Thanks. I'm just scratching an itch here (have a new GX1 and I'm going on 
vacation with it in a couple of weeks - I used Photivo with my old G1 but have 
had to fall back to the much-less capable Rawtherapee for now).

I'll just sent you a patch this time (assuming I get it working). I'll leave 
you to decide if I'm sending you so many annoying patches that you'd rather 
give me push access. ;)

Original comment by frasermc...@gmail.com on 17 Jul 2012 at 6:05

GoogleCodeExporter commented 9 years ago
Sure, just go ahead.

Original comment by m...@mm-log.com on 17 Jul 2012 at 6:42

GoogleCodeExporter commented 9 years ago
Just an update: I'm making progress, but there are a lot of changes so it's 
slow going. I also plan to fix the update.sh script - the current version makes 
a lot of mistakes on the newer dcraw.c source (for example, raw_image becomes 
raw_m_Image instead of m_RawImage), since it doesn't respect word boundaries.

Original comment by frasermc...@gmail.com on 21 Jul 2012 at 1:18

GoogleCodeExporter commented 9 years ago
I',m very interested on this task, because I'm using a Fuji X-Pro1, which is 
supported by the dcraw 9.16 version.

Are there any photivo sources with draw 9.16?
Maybe I could help to compile a OSX (Mountain Lion) version of photivo. I setup 
OSX for compiling with some quirks which has to be fixed, but I'm optimistic to 
be successfull, if I have sources with the latest drcraw.

Original comment by ishan.an...@googlemail.com on 10 Aug 2012 at 7:12

GoogleCodeExporter commented 9 years ago
Up to my knowledge, no. 

@frasermccrossan: Any news, any progress? Do you need any help?

greets mike

Original comment by m...@mm-log.com on 11 Aug 2012 at 10:05

GoogleCodeExporter commented 9 years ago
Sorry, I was in the middle of fixing compilation problems after updating the 
code. Unfortunately I haven't touched the code for about 2 weeks due to a 
family illness and a home break-in, and I don't expect to be able to continue 
for another 2 weeks or so. I also can't send you my progress so far, although 
it is saved. I don't know what to suggest other than either wait or for someone 
else to start it independently. Sorry about that.

Original comment by frasermc...@gmail.com on 11 Aug 2012 at 11:00

GoogleCodeExporter commented 9 years ago
Thank's for your feedback.
I'm not programmer enough to that task independently.
So I wait till support for the X-Pro1 is available in Photivo.

Wish you all the best
Ishan

Original comment by ishan.an...@googlemail.com on 12 Aug 2012 at 2:13

GoogleCodeExporter commented 9 years ago
I had a short look yesterday. Meanwhile dcraw made a quite large step between 
1447 and 1448. I updated Photivo to 1447 yesterday, but for the big step to 
1448 I need to see, when I have time for it. Unlucky for you, X-Pro 1 was 
introduced with 1448.

greets mike

Original comment by m...@mm-log.com on 12 Aug 2012 at 2:24

GoogleCodeExporter commented 9 years ago
FWIW my updates were aimed at 1.451 but as I mentioned I won't be able to get 
to it for a while. Once I do I'll probably redo it for 1.452.

Original comment by frasermc...@gmail.com on 12 Aug 2012 at 4:15

GoogleCodeExporter commented 9 years ago
Sure 1452 is the goal, but since 1447 to 1448 is a quite large step, I want to 
go in three steps: 1445-1447 (done), 1447-1448, 1448-1452... 

Original comment by m...@mm-log.com on 12 Aug 2012 at 4:29

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Update with dcraw 1448 is pushed to the source code repo (though up to now 
without profiles, those will follow).

Please test your Lumix DMC-GX1 Raws.

Greets mike

Original comment by m...@mm-log.com on 23 Aug 2012 at 7:32