search

hobbyquaker / node-red-contrib-polymer

A Polymer based Dashboard UI for Node-RED
MIT License
21 stars 0 forks source link

Feature request: Page - make sidebar optional #19

Closed M0ebiu5 closed 7 years ago

M0ebiu5 commented 7 years ago

It should be optional to show the sidebar (or menu). Now, depending on the screen size, the sidebar or menu is shown.

hobbyquaker commented 7 years ago

Will do this asap, will create a few more options that can be configured in a site-node

hobbyquaker commented 7 years ago

You can now hide the menu on screens >640px width, take a look at the options of the "Site" node. If this is satisfying for you pls close this issue

M0ebiu5 commented 7 years ago

"Hide menu" option works, but if you activate the side menu and click on the entry of the already opened page, it wont close. Also the cursor changes into a caret, when hovering over the entry.

hobbyquaker commented 7 years ago

True, but you can still swipe the menu away or close it by clicking right of it, don't you? Do you see this as a bug that has to be fixed? Thing is that the menu closing is triggered by the page-change event - and if you click on the page you already are there is no change ;)

M0ebiu5 commented 7 years ago

I wouldnt call it a bug rather than an "unelegancy" :) It's a little confusing, but if it's hard to fix, we should move on...

M0ebiu5 commented 7 years ago

Sorry, but "close menu when clicked on active item (closes #19)" is not working here (chrome).

hobbyquaker commented 7 years ago

i fear this is caused by touch vs click. You tested it on a touch device?

M0ebiu5 commented 7 years ago

I tested both - with touch (Android) and click (Win) It's super low priority - if it's difficult, dont waste too much time on it...

M0ebiu5 commented 7 years ago

Fixed with 0.0.7