Closed autonome closed 6 years ago
hobinjk
commented
6 years ago I pushed a commit that does the constant moving and documentation. What do you mean by the CLI example? There's a node translator.js "aaa" "bbb" in the README already although it might not be highlighted that well.
autonome
commented
6 years ago sorry that wasn't clear 😅 yeah i was talking about the ability to pass url/token on the command line. but i'd started reading at the Troubleshooting section so didn't read the top, so never mind!
On Wed, May 9, 2018 at 9:28 AM James Hobin notifications@github.com wrote:
I pushed a commit that does the constant moving and documentation. What do you mean by the CLI example? There's a node translator.js "aaa" "bbb" in the README already although it might not be highlighted that well.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hobinjk/gateway-prometheus-translator/issues/1#issuecomment-387797300, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDt4UXpDLIAh6se7Jdj9N28YxlmvIJks5twxk4gaJpZM4T4mrJ .
I just followed the instructions for permanent installation, and recommend a couple of minor changes:
make the URL and tokens const instead of the current inline assignment (or use the consts in the inline assignment).
have the const declarations up at the top, clearly documented.
Also would be good to have the CLI example noted in the README, so people can easily add as cron job, etc.