"Close Current Page on Add" does not work when adding a tab to the stack

[NamelessVoice]

When adding a tab to the stack using one of the following methods:

• Drag the tab from the tab bar into the Bookstack sidebar
• Right-click on a tab in the tab bar and add choose "Add this tab to stack"

The tab is not automatically closed, even with the "Close Current Page on Add" option enabled.

Note: that right-clicking on a page's content area and selecting "Add this page to stack" does correctly close it.

Observed while using Tab Mix Plus and Tab Groups. Disabling Tab Mix Plus did not resolve the issue.

[hobophobe]

This is fixable for the tab context menu.

I'm pretty sure it won't be for dragging tabs, because bookstack relies on Firefox code for the drag and drop rather than maintaining it separately, and duplicating all that code for this is a lot for a little.

I'll look at it again when I get a chance to implement the tab context menu fix.

[NamelessVoice]

Whenever I drag a tab into the sidebar, Firefox selects / opens that tab (even if it was previously not the in-focus tab.) Even if you don't have access to information about the tab, you should just be able to "close current tab" upon drag-and-drop. That's assuming you have some kind of event you can hook into when a drag-and-drop completes.

As an aside, would it be possible to make it open the bookmarks in a new tab by default, without having to middle-click? Or is that also part of the standard Firefox functionality?

[hobophobe]

As an aside, would it be possible to make it open the bookmarks in a new tab by default, without having to middle-click? Or is that also part of the standard Firefox functionality?

It could be done (it used to have that option), but I'd prefer not to add more options. You can also Ctrl+click to open in a new tab, if that helps.