Closed Blind4Basics closed 2 years ago
Blind4Basics
commented
2 years ago Changes done. I believe I didn't break anything while doing so.
There is still the question about keeping or not the buildPolyglotConfigMenu in the LISTENER_CONIFG and the onceOnly weirdness, with the syntax shortcuts I use there.
Blind4Basics
commented
2 years ago note: https://github.com/codewars/codewars.com/issues/1272
kazk just made the language dropdown thing useless too. Do I clean up here or do you remove the useless stuff after merging the PR?
I believe you actually can get rid of the part gathering solutions too, now? If so, would be good to add an automatic teardown of the localestorage (or whatever the place you store the data about solutions) in the next version of the script, no?
hobovsky
commented
2 years ago note: codewars/codewars.com#1272
kazk just made the language dropdown thing useless too. Do I clean up here or do you remove the useless stuff after merging the PR?
No need, I will address it in a PR dedicated to removal of the function.
I believe you actually can get rid of the part gathering solutions too, now? If so, would be good to add an automatic teardown of the localestorage (or whatever the place you store the data about solutions) in the next version of the script, no?
Yes, we dont need to store information about user solutions anymore, and I will try to remove it from users local storage.
Blind4Basics
commented
2 years ago Yes, we dont need to store information about user solutions anymore, and I will try to remove it from users local storage.
note: it seems like there isn't support for the "completed kata" page on the user's profile yet. But I guess that's "next up" for kazk?
separating the configuration of the DOM listeners from the actual code/executions.
You might wanna move the new functions near the end of the file...