#446 Filtered main_subjects to remove duplicates

hochschule-darmstadt / openartbrowser

Exploring the world of arts using open data

http://openartbrowser.org/

MIT License

40 stars 10 forks source link

#446 Filtered main_subjects to remove duplicates #485

Closed FabioBurillo closed 3 years ago

FabioBurillo commented 3 years ago

This branch fixes the issue #446.

The main_subjects array is filled with objects, which are gotten from the data service through ids. Because the data service function returns all objects with the given ids, the array contained duplicate objects.

Only the objects with a type equals 'motif' were necessary, so I filtered the main_subjects array to remove the other ones.

Now there are only singular entries under 'HauptMotive' and they link correctly to the motifs.

tpachmann commented 3 years ago

Oh btw, I'm not completely sure about the branching model - but I think we're supposed to merge to the staging branch before releasing to the master branch (@DPhuongHda correct me if I'm wrong)..

DPhuongHda commented 3 years ago

Yeah, this shouldn't be happening. @FabioBurillo could you change it to staging?

FabioBurillo commented 3 years ago

Oh yeah thanks. Was my first pull request and I guess I missed that. Is it alright now or did I miss anything else? @DPhuongHda @tpachmann

EeveesEyes commented 3 years ago

This looks good, you can merge it :)