search

hochschule-darmstadt / openartbrowser

Exploring the world of arts using open data
http://openartbrowser.org/
MIT License
40 stars 10 forks source link

#417 rebuilds countEntityItems() query using bodybuilder which could fix the issue #488

Closed DavidReyer closed 3 years ago

DavidReyer commented 3 years ago

The number of entities is missing in the staging and live versions of the OAB. This issue was not present if the application was run locally.

The query executed to count all items of a given EntityType was a manual elasticsearch query. The query is now reqritten using bodybuilder. Locally this query works (as did the previous one). To test if this fixes the issue this fix has to be incorporated in the staging environment as the bug is only apparent there.

DavidReyer commented 3 years ago

f21dd37 intends to add the mentioned two way binding between the entities component and the fetching list. This encompasses event emitters in the fetching list on init and on update and an options variable in the entities component to store the information following this angular two-way-binding tutorial.

DavidReyer commented 3 years ago

9977049 Fixes the translation issue. It was caused by the translation engine replacing the content of the span containing the "All X" of "All X Artists" with the translated version ob "All" omitting the number. Splitting the title into 3 seperate spans: "All", "X" and "Artists" fixes this.