search

hochschule-darmstadt / openartbrowser

Exploring the world of arts using open data
http://openartbrowser.org/
MIT License
40 stars 10 forks source link

#561 Tweaked the style of the scrollbar #571

Closed GiotisK closed 3 years ago

GiotisK commented 3 years ago

issue #561 Changed the style of slider like how it is shown below.

slider

GiotisK commented 3 years ago

Forgot to mention that i ran "npm install" after cloning the repo because the "ng serve" command didn't work as it was missing some dependecies

vinoroidski commented 3 years ago

@GiotisK : 👍

May I ask from where you saw our project and why you wanted to change the scroll bar? :)

GiotisK commented 3 years ago

@GiotisK : 👍

May I ask from where you saw our project and why you wanted to change the scroll bar? :)

I found it through the site https://goodfirstissues.com. I want to start contributing to open source projects and I found it a good idea to start from here!

EeveesEyes commented 3 years ago

Awesome, thank you :+1: Two notes: please separate changes to the package-lock.json from features/the code. This makes it easier to track dependency changes. You can prevent changes to the package-lock.json by running npm ci. And please change the base/target branch to 'staging' as everything there is tested before it gets released.

Nevertheless, your contribution is very much welcome 💯

GiotisK commented 3 years ago

Awesome, thank you 👍 Two notes: please separate changes to the package-lock.json from features/the code. This makes it easier to track dependency changes. You can prevent changes to the package-lock.json by running npm ci. And please change the base/target branch to 'staging' as everything there is tested before it gets released.

Nevertheless, your contribution is very much welcome 💯

Sure. I will look into it asap. If I come across to any problems with these things you mentioned, can I tag you here for possible help? Thank you. It will be interesting and fun to contribute in this repo.

EeveesEyes commented 3 years ago

If I come across to any problems with these things you mentioned, can I tag you here for possible help?

Sure, I'm happy to help :)

GiotisK commented 3 years ago

I still have some problems understanding the things you mentioned. Things that I tried to do: 1) I cloned the repo again with the goal of not messing with the package-lock.json 2) I ran npm ci in the app folder but it gives me access rights errors.

EeveesEyes commented 3 years ago

I'm not sure why you get access rights errors, can you send the error message? Maybe you can simply revert your changes to the package-lock.json? There is a dependency to https://github.com/hochschule-darmstadt/ngx-image-viewer , maybe this is a problem?

GiotisK commented 3 years ago

I'm not sure why you get access rights errors, can you send the error message? Maybe you can simply revert your changes to the package-lock.json? There is a dependency to https://github.com/hochschule-darmstadt/ngx-image-viewer , maybe this is a problem?

I managed to revert the changes and also changed the base branch to 'staging'. You can check it out and let me know if there is any problem. Thank you for the valuable help!