hockeymikey / android_device_sony_lilac

Sony XZ1C for RR
1 stars 0 forks source link

Verizon support #69

Open hockeymikey opened 3 years ago

asdf2345 commented 2 years ago

I think that's more an issue with the phone hardware and not the software? Also maybe you should just make a LineageOS 15.1 ROM instead. It has a lot less issues, and if I remember correctly, still has official support.

hockeymikey commented 2 years ago

@asdf2345 Kinda, not really. So we don't have the CMDA bands but full LTE bands including the important band 13. It's more a question of forcing Verizon and getting it on there. Someone has done it and when I have time and I will test it further and hopefully get it working. And I have no interest in a LineageOS 15.1 build. It doesn't have that many features especially compared to ResurrectionRemix. RR is just LineageOS too so there is no real difference. Just means more work pulling down from upstream which isn't hard. Will work on it more when I start the Phd.

hockeymikey commented 2 years ago

I mean if someone REALLLLY wants a LineageOS 15.1 build, I suppose I'd monkey alittle with it, but I'm not dumping much time into it at all. RR is my baby.

hockeymikey commented 2 years ago

Unless someone pays me. I'll do alot for money, lmao

asdf2345 commented 2 years ago

And I have no interest in a LineageOS 15.1 build. It doesn't have that many features especially compared to ResurrectionRemix. RR is just LineageOS too so there is no real difference.

I'm fine with less features, everything I want (except screen off animations and fingerprint unlocking after boot) can be done with LineageOS and Gravitybox. I haven't seen some of the bugs I experience with this ROM with the dead LineageOS ROM, like always linked ringtone and notification volumes, broken splitscreen, apps not able to control navigation bar, warm tinted display, navigation bar having no ring, camera icons off the screen, Google apps existing, bright at even lowest brightness, and more.

hockeymikey commented 2 years ago

I'm fine with less features, everything I want (except screen off animations and fingerprint unlocking after boot) can be done with LineageOS and Gravitybox.

GravityBox doesn't have notification tickers which is the big deal breaker for me and how I got here. I'm not fine with less features, hence why I chose RR and added my own features like signature spoofing.

I haven't seen some of the bugs I experience with this ROM with the dead LineageOS ROM, like always linked ringtone and notification volumes

Unless that's a feature, I have no idea. Should be an easy fix I think or an option.

broken splitscreen

Like stacked apps? Works for me.

apps not able to control navigation bar

Control how?

warm tinted display

I still don't see this. Both of my devices look the same. Is LiveDisplay on by chance?

navigation bar having no ring

Probably because you don't have that virtual assistant installed or whatever. I don't see a visual issue with it either. They all look about the same height.

camera icons off the screen

What camera icon?

Google apps existing

What google apps? I don't run any gapps, only microg. I recommend that Magick module for it.

bright at even lowest brightness

This is valid and still bugs me, haha.

RR is still probably my sole focus. I have no desire to use LOS and bar financial incentive to work on the later.

asdf2345 commented 2 years ago

GitHub never sent me an email saying that you replied, so response is late.

Unless that's a feature, I have no idea. Should be an easy fix I think or an option.

See the issue I posted a while back https://github.com/hockeymikey/android_device_sony_lilac/issues/72

Like stacked apps? Works for me.

Hmm, it's broken for me. What stock ROM did you use before flashing RR, and are you running a newer compile than is public?

Control how?

See the issue I posted a while back https://github.com/hockeymikey/android_device_sony_lilac/issues/64

I still don't see this. Both of my devices look the same. Is LiveDisplay on by chance?

See the issue I posted a while back https://github.com/hockeymikey/android_device_sony_lilac/issues/59

Probably because you don't have that virtual assistant installed or whatever. I don't see a visual issue with it either. They all look about the same height.

I don't, however LineageOS comes with no assistant but still has the ring.

What camera icon?

Icons, and see the issue I posted a while back https://github.com/hockeymikey/android_device_sony_lilac/issues/57

What google apps? I don't run any gapps, only microg. I recommend that Magick module for it.

See the issue I posted a while back https://github.com/hockeymikey/android_device_sony_lilac/issues/55

hockeymikey commented 2 years ago

GitHub never sent me an email saying that you replied, so response is late.

No worries, my responses can be slow too depending on my personal life.

Like stacked apps? Works for me.

Hmm, it's broken for me. What stock ROM did you use before flashing RR, and are you running a newer compile than is public?

47.1.A.16.20 the last Oreo version and no, I run the most latest version posted here. I test on my backup with new stuff, but my main phone I only run the most stable.

Probably because you don't have that virtual assistant installed or whatever. I don't see a visual issue with it either. They all look about the same height.

I don't, however LineageOS comes with no assistant but still has the ring.

Hmmm, I'd say it's a bug on LineageOS end then, since this visual feature is supposed to show if an assistant is available and if not if it's isn't. I mean if it doesn't appear when there is one then I guess that is another question to fix that.

asdf2345 commented 2 years ago

47.1.A.16.20 the last Oreo version and no, I run the most latest version posted here. I test on my backup with new stuff, but my main phone I only run the most stable.

Can you give me the specific copy of 47.1.A.16.20 you use? I have fixed my volume buttons so I can flash.

Hmmm, I'd say it's a bug on LineageOS end then, since this visual feature is supposed to show if an assistant is available and if not if it's isn't. I mean if it doesn't appear when there is one then I guess that is another question to fix that.

I think they just have it display always because it looks proper, having no ring looks odd.

hockeymikey commented 2 years ago

47.1.A.16.20 the last Oreo version and no, I run the most latest version posted here. I test on my backup with new stuff, but my main phone I only run the most stable.

Can you give me the specific copy of 47.1.A.16.20 you use? I have fixed my volume buttons so I can flash.

https://mnscu-my.sharepoint.com/:u:/r/personal/ra6638tw_go_minnstate_edu/Documents/xz1c/G8441_Customized%20US_1310-4371_47.1.A.16.20_R8B.zip?csf=1&web=1&e=32yo3U

Try this one. I think this is the one I used.

Hmmm, I'd say it's a bug on LineageOS end then, since this visual feature is supposed to show if an assistant is available and if not if it's isn't. I mean if it doesn't appear when there is one then I guess that is another question to fix that.

I think they just have it display always because it looks proper, having no ring looks odd.

I can look into that for a feature, fold it into the nav bar customization. I think the ring looks weird and less clean personally.

asdf2345 commented 2 years ago

https://mnscu-my.sharepoint.com/:u:/r/personal/ra6638tw_go_minnstate_edu/Documents/xz1c/G8441_Customized%20US_1310-4371_47.1.A.16.20_R8B.zip?csf=1&web=1&e=32yo3U

That takes me to a login page.

hockeymikey commented 2 years ago

https://mnscu-my.sharepoint.com/:u:/g/personal/ra6638tw_go_minnstate_edu/Ecec3o8t2IlDpW0x2gq2-YMBPVWX4jjdzKGJzb_6upb-yA?e=lwBsP6

K4sum1 commented 4 months ago

I mean if someone REALLLLY wants a LineageOS 15.1 build, I suppose I'd monkey alittle with it, but I'm not dumping much time into it at all. RR is my baby.

I have the resources to do builds, and I would be interested in making a LineageOS 15.1 build. However I haven't had much luck building 15.1 in the modern era, so I'm wondering if you could help me with it please.

K4sum1 commented 3 months ago

So I was able to build my own LineageOS 15.1. However the camera app crashes at launch, and the phone does not detect the SIM card or IMEI with it. I used your sources with some light modifications to make them work for LineageOS. I don't know what the issue would be here.

hockeymikey commented 3 months ago

@K4sum1 strange, me neither. Maybe too old of kernels? Is it all sims or just verzion? Was it detected before?

K4sum1 commented 3 months ago

Kernel should be the same I think between yours and mine. It's all sims, the IMEI is just gone. and the issue persists until I revert to stock, or switch to your ROM and apply a modem profile.

For now I just want to try building RR O as a baseline, so I installed 20.04 to try and I'm getting an error that I don't know how to get past. (I was able to build a broken 15.1 with this same setup)

image

Little low res since I'm remoting into it from a lower screen resolution PC

K4sum1 commented 3 months ago

Now I can't even get a working boot.img building 15.1. I don't know what I'm doing wrong. Please help.

I might have the everything being kinda broken issue fixed, but I can't test.

K4sum1 commented 3 months ago

I'm building from my repos, which are forks of the whatawurst repos. I tried going back to modifying your repos and still have broken boot.img.

https://github.com/Eclipse-Community/android_device_sony_lilac_oreo

On top of the instructions there, I do this before building. This supposedly is the fix to the everything being kinda broken issue.

cd bionic
git revert 2de89a8d9d552f7bc4cd68f23c1a22b0715fd9c1 --no-commit
cd ../build/make
git revert 784fbae86ac177f820777d47c2fe8b121c6960ab --no-commit
K4sum1 commented 3 months ago

I found an old copy of my 22.04 VM and only that one works. I have no idea why. Also yes I have fixed my issues woo

K4sum1 commented 3 months ago

https://github.com/Eclipse-Community/build_lineage/releases/tag/lineage-15.1-20240828-lilac

K4sum1 commented 3 months ago

You might also want to undo this commit https://github.com/hockeymikey/repo_update/commit/c36a63720581eee3402cd6663761f7c04e9d06ae Not having those commits applied will massively fuck up the output and give you my issue, and not working WiFi on top of that.