search

hodcroftlab / covariants

Real-time updates and information about key SARS-CoV-2 variants, plus the scripts that generate this information.
https://covariants.org/
GNU Affero General Public License v3.0
316 stars 111 forks source link

Add US state code "flags" #209

Closed richardgoater closed 2 years ago

richardgoater commented 3 years ago

Hi folks! Hope you're well. This is one idea I mentioned a while back.

I think the types for the flag components are slightly unresolved atm, it probably needs a generic flag interface.

Let me know what you think 😃

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hodcroftlab/covariants/Gw4vhm7Qb9NKYrFpcqMeJ3XhTXBe
✅ Preview: https://covariants-git-fork-richardgoater-us-state-codes-hodcroftlab.vercel.app

ivan-aksamentov commented 3 years ago

Thanks, Richard @richardgoater

Looks pretty!

On the technical side though, should we just hardcode all the states? We don't expect any more states added, right?

Hardcoding would remove the 3rdpary dependency (and the really old version of lodash it depends on for some reason) and should simplify the code significantly. I mostly worry about all the null checks.

Here is what I would do:

Or do you plan on using the library for something else?

richardgoater commented 3 years ago

Hi @ivan-aksamentov, I completely agree, I was just being lazy. Thanks very much for writing up a "migration guide"! I should be able to do it tomorrow.

richardgoater commented 3 years ago

think that should be done now, let me know what you think 👍🏽

emmahodcroft commented 2 years ago

If we can resolve the couple of merge conflicts on this, I'm happy to merge it in!

richardgoater commented 2 years ago

~Thanks! I'll take a quick look :)~

EDIT: thanks @ivan-aksamentov !

emmahodcroft commented 2 years ago

Looks like Ivan's on it ;) I'll wait for the deploy after the merge, but if all seems to have gone without a hitch, we can merge it in!

ivan-aksamentov commented 2 years ago

Yeah it conflicted with my continent flags feature really badly. I think I might have resolved it now.

I also made US state codes to be in monospace font (all letters have same width) so that narrow letters don't make things wobble as you go through the list. (e.g everything that has and "i" or "j", like Indiana or New Jersey). How do you like it?

Before After
Also we don't have a code for the Mariana state. Never heard of it and don't know what should be there. Please double check everything, because merge was somewhat painful and required a few attempts.
ivan-aksamentov commented 2 years ago

Alright, according to https://en.wikipedia.org/wiki/Northern_Mariana_Islands "Northern Mariana Islands" should have code "MP". I added it. Sounds good?

emmahodcroft commented 2 years ago

I've gone through this and it looks great to me Ivan - thanks! Not sure I'd have noticed the font spacing, but I agree it looks nice with it all taking up the same amount of space! And I've never heard of the Mariana Islands either... 🤔

Shall we wait for the deploy to finish to ensure all is good? Then we can merge.

emmahodcroft commented 2 years ago

Ok, deploy went fine - I'll merge in!

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.