Closed richardgoater closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/hodcroftlab/covariants/Gw4vhm7Qb9NKYrFpcqMeJ3XhTXBe
✅ Preview: https://covariants-git-fork-richardgoater-us-state-codes-hodcroftlab.vercel.app
Thanks, Richard @richardgoater
Looks pretty!
On the technical side though, should we just hardcode all the states? We don't expect any more states added, right?
Hardcoding would remove the 3rdpary dependency (and the really old version of lodash it depends on for some reason) and should simplify the code significantly. I mostly worry about all the null checks.
Here is what I would do:
Or do you plan on using the library for something else?
Hi @ivan-aksamentov, I completely agree, I was just being lazy. Thanks very much for writing up a "migration guide"! I should be able to do it tomorrow.
think that should be done now, let me know what you think 👍🏽
If we can resolve the couple of merge conflicts on this, I'm happy to merge it in!
~Thanks! I'll take a quick look :)~
EDIT: thanks @ivan-aksamentov !
Looks like Ivan's on it ;) I'll wait for the deploy after the merge, but if all seems to have gone without a hitch, we can merge it in!
Yeah it conflicted with my continent flags feature really badly. I think I might have resolved it now.
I also made US state codes to be in monospace font (all letters have same width) so that narrow letters don't make things wobble as you go through the list. (e.g everything that has and "i" or "j", like Indiana or New Jersey). How do you like it?
Before | After |
---|---|
Hi folks! Hope you're well. This is one idea I mentioned a while back.
I think the types for the flag components are slightly unresolved atm, it probably needs a generic flag interface.
Let me know what you think 😃